Skip to content

{AKS} az aks create: Raise a ClientRequestError when creating the same cluster again#5999

Merged
zhoxing-ms merged 6 commits intoAzure:mainfrom
FumingZhang:fuming/fix-dup-create-0315
Mar 20, 2023
Merged

{AKS} az aks create: Raise a ClientRequestError when creating the same cluster again#5999
zhoxing-ms merged 6 commits intoAzure:mainfrom
FumingZhang:fuming/fix-dup-create-0315

Conversation

@FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Raise an explicit ClientRequestError when creating the same cluster again with command az aks create, the message message would be something like

The cluster '<cluster-name>' under resource group '<resource-group-name>' already exists. Please use command 'az aks update' to update the existing cluster, or select a different cluster name to create a new cluster.

Added a new live test case test_aks_create_again_should_fail.

Related command

az aks create

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@ghost ghost requested review from yanzhudd and zhoxing-ms March 15, 2023 10:00
@ghost ghost assigned zhoxing-ms Mar 15, 2023
@ghost ghost added this to the March 2023 (2023-04-04) milestone Mar 15, 2023
@ghost ghost added the Auto-Assign Auto assign by bot label Mar 15, 2023
@ghost ghost requested a review from yonzhan March 15, 2023 10:00
@ghost ghost added the AKS label Mar 15, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 15, 2023

AKS

@FumingZhang FumingZhang force-pushed the fuming/fix-dup-create-0315 branch from 2c9304f to fec96e3 Compare March 20, 2023 09:39
@FumingZhang FumingZhang marked this pull request as ready for review March 20, 2023 09:56
@zhoxing-ms zhoxing-ms merged commit 6f43e09 into Azure:main Mar 20, 2023
@FumingZhang FumingZhang deleted the fuming/fix-dup-create-0315 branch April 10, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants